refactor(ssr): remove RenderMode.AppShell in favor of new configuration option
#28818
+174
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
render-mode-app-shell-remove
branch
from
8782827 to
72a99a5
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
render-mode-app-shell-remove
branch
from
72a99a5 to
b8c369c
Compare
alan-agius4
force-pushed
the
render-mode-app-shell-remove
branch
2 times, most recently
from
298dd63 to
a4a9cb7
Compare
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Nov 8, 2024
dgp1130
approved these changes
Nov 8, 2024
alan-agius4
added
action: cleanup
…configuration option
This commit removes the `RenderMode.AppShell` option. Instead, a new configuration parameter, `{ appShellRoute: 'shell' }`, is introduced to the `provideServerRoutesConfig` method.
```ts
provideServerRoutesConfig(serverRoutes, { appShellRoute: 'shell' })
```
alan-agius4
force-pushed
the
render-mode-app-shell-remove
branch
from
a4a9cb7 to
adaa3bc
Compare
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
thePunderWoman
pushed a commit
to angular/angular
that referenced
this pull request
Nov 8, 2024
…58564) More context in angular/angular-cli#28818 PR Close #58564
thePunderWoman
pushed a commit
to angular/angular
that referenced
this pull request
Nov 8, 2024
…58564) More context in angular/angular-cli#28818 PR Close #58564
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
RenderMode.AppShelloption. Instead, a new configuration parameter,{ appShellRoute: 'shell' }, is introduced to theprovideServerRoutesConfigmethod.